Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade the Dart/Flutter SDK to v4 #2599

Merged
merged 56 commits into from
Nov 26, 2020
Merged

Upgrade the Dart/Flutter SDK to v4 #2599

merged 56 commits into from
Nov 26, 2020

Conversation

marandaneto
Copy link
Contributor

@marandaneto marandaneto commented Oct 27, 2020 •
edited
Loading

To address:

  1. Should we create the Dart platform and make this a fallback to Flutter? like Java/Android
  2. Should we make Dart v3 a legacy like Java does and new docs are only v4? (Like Java v1 and v3)
  3. Do we need a migration page or just the new docs like Java docs? so with all the samples, people can learn the difference anyway.

cc @bruno-garcia @rxlabz
open for early feedback, obviously there's nothing yet, but the questions above would be nice to discuss @bruno-garcia

@vercel
Copy link

vercel bot commented Oct 27, 2020 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sentry/sentry-docs/4ka30p6wo/sentry.dev
✅ Preview: https://sentry-docs-git-ref-flutter-v4.sentry.dev

@marandaneto
Copy link
Contributor Author

Flutter platform only for now.
PR for flutter cookbook once v4 is GA.
Migration page.

bruno-garcia
bruno-garcia reviewed Oct 27, 2020
View reviewed changes
src/platforms/flutter/index.mdx Outdated Show resolved Hide resolved
src/platforms/flutter/index.mdx Outdated Show resolved Hide resolved
@marandaneto marandaneto mentioned this pull request Oct 27, 2020
Merged
8 tasks
@marandaneto
Copy link
Contributor Author

marandaneto commented Oct 28, 2020 •
edited
Loading

TODO (if they make sense):

decluttering
drain-example
getting-started-next-steps
getting-started-primer

bruno-garcia
bruno-garcia reviewed Nov 25, 2020
View reviewed changes
Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful :)

image

It's odd that we say Health here because there's no support for release health. But the docs talk about release which makes sense.

image

IHMO showing this is just noise and should be deleted:
image

Can we opt out from this?

src/platforms/dart/index.mdx Show resolved Hide resolved
src/platforms/dart/index.mdx Outdated Show resolved Hide resolved
src/platforms/dart/index.mdx Show resolved Hide resolved
src/includes/configure-scope/dart.mdx Outdated Show resolved Hide resolved
src/platforms/dart/config.yml Outdated Show resolved Hide resolved
src/platforms/flutter/config.yml Outdated Show resolved Hide resolved
src/platforms/flutter/config.yml Show resolved Hide resolved
src/platforms/flutter/index.mdx Outdated Show resolved Hide resolved
src/wizard/dart/index.md Outdated Show resolved Hide resolved
marandaneto
marandaneto commented Nov 25, 2020
View reviewed changes
src/wizard/dart/index.md Outdated Show resolved Hide resolved
bruno-garcia
bruno-garcia approved these changes Nov 25, 2020
View reviewed changes
Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 last fix: Hide the User Feedback page:

https://sentry-docs-git-ref-flutter-v4.sentry.dev/platforms/flutter/enriching-events/user-feedback/

Other than that looks good to merge already! We can do another iteration after that for any details

@marandaneto
Copy link
Contributor Author

1 last fix: Hide the User Feedback page:

https://sentry-docs-git-ref-flutter-v4.sentry.dev/platforms/flutter/enriching-events/user-feedback/

Other than that looks good to merge already! We can do another iteration after that for any details

good catch, I've hidden for dart but looks like we need both

@marandaneto marandaneto merged commit 013c875 into master Nov 26, 2020
@marandaneto marandaneto deleted the ref/flutter-v4 branch November 26, 2020 09:22
@github-actions github-actions bot locked and limited conversation to collaborators Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MimiDumpling MimiDumpling MimiDumpling left review comments

@rxlabz rxlabz rxlabz left review comments

@bruno-garcia bruno-garcia bruno-garcia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@marandaneto @bruno-garcia @rxlabz @MimiDumpling